Repository navigation
fix(agents): load OpenCode reviewer from the Claude persona - #4355
Open
matthewgrossman wants to merge 2 commits into
Open
matthewgrossman wants to merge 2 commits into
matthewgrossman wants to merge 2 commits into
Conversation
Move the reviewer persona to .agents/agents/ and symlink .claude/agents and .opencode/agents to it, replacing the stale OpenCode copy. Use frontmatter both harnesses accept: OpenCode drops agents with a Claude tools allowlist, so restrict Claude with disallowedTools instead. Point gator's manifest and test at the new path. Closes #4354 Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Replace the symlinked .agents/agents layout with a .opencode/opencode.jsonc
entry whose system prompt uses {file:} to read the Claude persona. The
Claude reviewer keeps its tools allowlist, and gator keeps reading the
existing path.
Closes #4354
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
marked this pull request as ready for review
October 8, 2026 23:40
matthewgrossman
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 8, 2026 23:40
johntmyers
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenCode now loads
principal-engineer-reviewerfrom the same file Claude Code and gator use,.claude/agents/principal-engineer-reviewer.md. Before this, the OpenCode copy was a separate file that had drifted behind the Claude copy.Related Issue
Closes #4354
Changes
.opencode/agents/principal-engineer-reviewer.md..opencode/opencode.jsoncwith aprincipal-engineer-reviewersubagent entry. Itssystemprompt uses{file:../.claude/agents/principal-engineer-reviewer.md}, and its permissions deny edits..claude/README.mdto say OpenCode loads the Claude personas, so there's only one copy to edit.The Claude persona, its
toolsallowlist, and gator are unchanged. The net diff againstmainis these three files. The first commit tried a symlinked.agents/agents/layout, and the second commit replaced it. Squash merging leaves only the final layout.Notes for reviewers:
toolsfield isn't a map. Claude's comma-separated or YAML-listtoolscan't be a map. Sharing one Markdown file therefore meant replacing Claude's allowlist with a broaderdisallowedToolsdenylist.{file:}isn't documented for OpenCode v2. It's carried over from v1 and works on v2.0.25. If the path breaks, OpenCode fails to load the project config, so the failure is visible rather than silent.Testing
opencode debug agents(v2.0.25) shows the reviewer as a subagent with edits denied, and its system prompt is identical to the Claude file.mise run license:checkpasses.Checklist