Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Label |
|
/ok-to-test 221cf8a |
|
/ok-to-test 860aa53 |
| XDG_RUNTIME_DIR: "/run/user/{{ tmachine_container_runtime_tmachine_uid.stdout }}" | ||
|
|
||
| - name: Run Podman E2E archive tests | ||
| become: "{{ not tmachine_container_runtime_is_rootless }}" |
There was a problem hiding this comment.
TESTING.md says e2e-podman requires rootless Podman, but this become adds a rootful path (and the PR description reports a rootful run passing). Should we document rootful as supported, or drop this branch and assert rootless?
There was a problem hiding this comment.
Yes, I'm looking into it now.
There was a problem hiding this comment.
Added the tmachine user to the podman group instead of requiring that the tests run as root.
|
/ok-to-test 135ce70 |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
135ce70 to
d598c03
Compare
Summary
Restore package-installed Podman driver qualification from #4107, which was reverted in #4206 after all three RPM lanes failed before executing their behavioral tests. The harness now follows the packaged service owner's actual XDG configuration path and supports services that run from defaults and
gateway.envwithout a TOML file.Related Issue
Follow-up to #3454 (already closed by #4107). This is a localized repair and reintroduction of that qualification harness; no new feature scope is added.
Original changes: #4107,
test(tmachine): support package-installed Podman driver suites. Revert: #4206.Changes
/var/lib/openshell-qualification/gateway.tomlassumption with the package service owner's XDGgateway.toml. Preserve the installed default profile; create a minimal versioned TOML only when a configured namespace profile needs an override and none exists.Testing
834b79a8c2351370e7c6c363423f5be18d440256(run); existing Rust archives compiled from the same source. Standard E2E workload image built locally.driver-podman: default, auto, keep-id, private; 8 test executions passed, zero skipped. Each profile creates a sandbox, verifies non-root workspace ownership/write access, compares its UID map with direct Podman, and deletes the sandbox.driver-podman: all four profiles; 8 test executions passed, zero skipped.e2e-podman: 27 tests passed as the local tmachine user with group socket access, the same 2 existing ignored tests skipped, in 526.292 seconds. Guest inspection confirmed nextest ran as tmachine. Final setup with the preserved packaged tmpfiles rules also passed all four rootful driver profiles (8 test executions, zero skips); an initial fresh-guest SSH startup timeout passed on retry.e2e-podman: 27 tests passed, 2 existing ignored tests skipped (manual Internet benchmark and the old user_namespaces scenario), in 400.882 seconds initially; the review correction rerun also passed 27 tests with the same 2 skips in 440.918 seconds.mise run pre-commitpassed, including the installed commit hook.mise run cistopped on the unmodified macOS VM testdriver::preparation::tests::completed_worker_without_descendants_keeps_successful_exit_statuswithOperation not permitted(220 VM tests passed). A targeted rerun passed; the full CI run did not complete.860aa5318, including all three RPM driver-specific jobs (E2E run).135ce70b9(Branch Checks, E2E).135ce70b9. Pre-commit and both commit hooks passed.d598c036c) is pending.test:e2eremains enabled; require actual integration jobs to pass before merging. A green workflow with skipped jobs is insufficient.Checklist