Skip to content

feat(e2e): preserve Kubernetes clusters for debugging - #3680

Open
danehans wants to merge 3 commits into
NVIDIA:mainfrom
danehans:feat/3675-preserve-kubernetes-e2e-cluster/danehans
Open

feat(e2e): preserve Kubernetes clusters for debugging#3680
danehans wants to merge 3 commits into
NVIDIA:mainfrom
danehans:feat/3675-preserve-kubernetes-e2e-cluster/danehans

Conversation

@danehans

@danehans danehans commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Add an opt-in mode that preserves wrapper-created Kubernetes E2E clusters and work directories for debugging while retaining existing cleanup by default.

Related Issue

Fixes: #3675

Changes

  • Validate the preservation option before creating resources.
  • Preserve only wrapper-owned clusters and print inspection, credential, and cleanup guidance.
  • Add deterministic coverage for success, failure, default cleanup, and caller-owned contexts.
  • Document the contributor workflow.

Testing

  • mise run pre-commit
  • mise run test:kubernetes-e2e-preserve
  • Live ephemeral k3d failure path preserved diagnostics, cluster, and work directory; retained resources were removed afterward.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@danehans
feat(e2e): preserve Kubernetes clusters for debugging
7b78449 
Keep wrapper-created clusters and work directories available for opt-in
failure investigation while retaining default and caller-owned cleanup.

Fixes: NVIDIA#3675
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@copy-pr-bot

copy-pr-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@danehans danehans mentioned this pull request Sep 24, 2026
Open
2 of 8 tasks
@danehans
docs(e2e): clarify existing cluster cleanup
0bff5c4 
Explain that preservation applies only to wrapper-created k3d clusters and
that existing-context runs retain their normal resource cleanup.

Fixes: NVIDIA#3675
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans
fix(e2e): require numeric preserve flag
34854bd 
Accept only 0 or 1 for the Kubernetes preservation option and cover the
rejection of boolean aliases before resource creation.

Fixes: NVIDIA#3675
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

This pull request has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity.

@github-actions github-actions Bot added the state:stale Inactive item at risk of automatic closure. label Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner
@sjenning sjenning Awaiting requested review from sjenning sjenning is a code owner
@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr derekwaynecarr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

state:stale Inactive item at risk of automatic closure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(e2e): preserve Kubernetes clusters for debugging

1 participant

@danehans