Repository navigation
Conversation
The mismatch guard was inverted, so the bypass warning printed when NRL_IGNORE_VERSION_MISMATCH was unset and nothing ever raised. Match the docstring: raise RuntimeError on mismatch, warn only when the bypass is requested. Signed-off-by: Liang Yan <lyan@coreweave.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_container_fingerprintsays a fingerprint mismatch raisesRuntimeErrorunlessNRL_IGNORE_VERSION_MISMATCHis set. The check is inverted: the bypass warning is logged when the variable is unset, and a mismatch never raises.Raise on mismatch. Warn and continue only when
NRL_IGNORE_VERSION_MISMATCHis set.Test plan
test_check_raises_on_mismatch_without_ignore_flagexpectsRuntimeErrortest_check_logs_warning_with_ignore_flagasserts the bypass warning