You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Crash when attaching multiple images to MessageInputBar #16
I encountered a crash when crash when inserting text followed by multiple pictures into the MessageInputBar.
The crash occurs in parseForComponents() located in InputTextView.swift.
The following line was the culprit:
let textRange = NSMakeRange(curLocation, range.location)
This worked fine on the first image, but subsequent images crashed because the length should be range.location-curLocation as below:
let textRange = NSMakeRange(curLocation, range.location-curLocation)
With this change it is now working.
Activity
tkeithblack commentedon Jan 7, 2019
I attempted to do a Pull Request, but may not have permission.
Here'a a screenshot in the debugger showing the fix
.
nathantannar4 commentedon Jan 7, 2019
Thanks @tkeithblack , want to make a PR?
Sent with GitHawk
tkeithblack commentedon Jan 7, 2019
nathantannar4 commentedon Jan 8, 2019
@tkeithblack If you fork MK to your own repo you can make a PR from tahr branch.
Sent with GitHawk
tkeithblack commentedon Jan 9, 2019
#17