Repository navigation
Strip trailing tab from parsed paths with spaces - #94
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a path contains a space, git ends the
---/+++lines with a tab and parse-git-diff keeps it, sojson-diffreports paths like"space name.txt\t"for added, changed, and deleted files. This strips that tab after parsing (renames were already correct since they come from therename from/tolines). CONTRIBUTING mentions this as a known parser quirk to fix separately, so this is that change.Added a fixture generated with real
git diffcovering all four file types, updated the acceptance test that was asserting the old value, and dropped the CONTRIBUTING note.script/allandscript/verify-bundlepass on Node 24.14.0 with 100% coverage.