Repository navigation
Clear _original_params after _generate and during SubFactory evaluation - #1160
Open
DYNOSuprovo wants to merge 1 commit into
Open
DYNOSuprovo wants to merge 1 commit into
DYNOSuprovo wants to merge 1 commit into
Conversation
Fixes FactoryBoy#1099 Signed-off-by: DYNOSuprovo <DYNOSuprovo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1099.
When a
DjangoModelFactoryorSQLAlchemyModelFactoryis called directly via.create(**params)or.build(**params),_generate()setscls._original_params = paramson the factory class so_get_or_create()can recover from anIntegrityErrorusing the caller-provided lookup fields. However:_generate()never resetcls._original_paramsback toNoneupon completion (or when an exception was raised), leaving stale parameters attached to the factory class across subsequent calls.SubFactory(which callsstep.recurse()directly rather than_generate()), the stalecls._original_paramsfrom the previous direct call remained set on the class. This caused_get_or_create()(or custom_create()methods inspecting_original_params) to use stale parameters from an earlier call instead ofNone.Changes
cls._original_params = Nonein atry ... finallyblock inDjangoModelFactory._generate()andSQLAlchemyModelFactory._generate()._original_paramson the targetsubfactoryduringSubFactory.evaluate()(and restore any outer_original_paramsafterward to support nested/self-referential subfactories).tests/test_django.pyandtests/test_alchemy.py.