Repository navigation
Conversation
Member
|
@giordano know what's up here? |
Member
|
PRs from forks don't work because of the secrets management. |
Member
|
Actually, maybe making the secrets optional and handling the case of them missing (they're only needed for registration, not the build itself) would do the trick |
Author
|
Ready |
Author
|
Friendly bump |
Member
|
It's ok from my point of view, but it's not clear to me what these options do. Do we really need to list one by one all the generations of AMD GPUs? That looks a bit unmanageable in the long term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.