Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
“Export with photos & videos” could write a ZIP that “Import backup” rejects. At commit
31c6795, 1,999 distinct media files produced 2,001 ZIP entries (backup JSON, media, and README). Export reported 1,999 included files, but importing that ZIP failed withtoo-many.Change
Make the ZIP writer enforce the reader’s 2,000-entry and 1 GiB entry-data limits. Exports beyond those limits now fail instead of producing a backup the app cannot restore.
Verification
31c6795.pnpm exec vitest run src/lib/zip.test.js src/lib/backup-media.test.js— 13 passed.pnpm exec vitest run— 3,163 passed across 256 files.