Repository navigation
Fix Coach routine icons and balance exercise candidates - #311
Merged
DuarteSantos8 merged 1 commit intoSep 28, 2026
Merged
DuarteSantos8 merged 1 commit into
DuarteSantos8 merged 1 commit into
Conversation
DuarteSantos8
added a commit
that referenced
this pull request
Sep 28, 2026
…f the app's icons or an emoji, so no text rides into later prompts through it, and a new plan is asked for an icon by name
DuarteSantos8
added a commit
that referenced
this pull request
Sep 28, 2026
…only as an icon key or an emoji, a flag passes only as one pair of letters, and the icon keys older routines hold survive a plan
DuarteSantos8
added a commit
that referenced
this pull request
Sep 28, 2026
Owner
|
Thanks @ameer-khan-ashraf. This was still a draft, but it was ready, so it went into v1.3.9 (the push marked it merged). Two follow-ups for safety, because the icon goes back into later prompts: a Coach routine icon is kept only if it's one of the app's icon keys or an emoji, a flag only as one pair of letters, and older routines keep their icon keys through a new plan. Released in v1.3.9: https://github.com/DuarteSantos8/openGym/releases/tag/v1.3.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Coach routine pickers and plan cards render routine glyphs through the existing icon system. Plan and review validation allow up to 32 characters for routine glyphs so keys such as
figureStrengthare preserved rather than truncated.The bounded exercise catalogue excludes stretches from unpinned candidates and uses weighted body-part lanes to give major training body parts more room. Equipment filtering, deterministic ordering, and pinned plan/history exercises remain supported; narrow candidate pools have fallbacks.
Why
Coach screens displayed icon keys as text and validation truncated them. An equal share of catalogue body parts also overrepresented stretches and small body parts in generated plan candidates.
Validation
git diff --checkpasses.Manual check before marking ready
Open a multi-routine Coach plan and the Improve routine picker. Confirm routine icons render correctly for current icon keys and legacy emoji. No hostname or passkey migration setup is required.
Checklist