Repository navigation
feat: keep rest timers Ready and support optional timed-set overtime - #204
Merged
DuarteSantos8 merged 2 commits intoSep 28, 2026
Merged
DuarteSantos8 merged 2 commits into
DuarteSantos8 merged 2 commits into
Conversation
DuarteSantos8
added a commit
that referenced
this pull request
Sep 28, 2026
… counts as running, so re-checking a finished set still starts the rest it owes
Owner
|
Thanks @Space-Hermes, the Ready state and the optional hold overtime are in. One fix on top: a rest that had run out and only showed Ready still counted as running, so re-ticking a finished set didn't start the rest it owed. That's sorted. Rest also got Pause/Resume in this release, and on Android the notification from #296 follows Ready too. Released in v1.3.9: https://github.com/DuarteSantos8/openGym/releases/tag/v1.3.9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rest timers now stay on Ready after reaching zero, so they can be dismissed or restarted with +15s. Timed sets gain an optional Keep timing after target setting, off by default: the timer shows overtime and Done logs the elapsed duration, with a 15-minute overtime cap. Cancel leaves the set unlogged.
This brings the focused GitLab !123 proposal onto v1.3.8 main (
f91cde15), following #140. Timer ownership, background expiry, per-device rest push and the merged iOS sound behavior are preserved. The per-kind sounds and automatic timer hand-over being developed in #165 remain in that PR.Validation: all 1,591 frontend tests pass across 127 files, production build passes, and the new strings pass all 14 locale checks and the pt-BR guard. Earlier browser checks at phone width covered overtime, Done, cancellation, persistent Ready, +15s restart and dismissal. Native background notifications and physical-device behavior still need device validation.