Repository navigation
fix: serve the refreshed icon at the old path - #82
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
lmjabreu
marked this pull request as ready for review
October 16, 2026 11:47
lmjabreu
requested review from
a team,
craigcarlyle and
gnapse
and removed request for
a team and
craigcarlyle
October 16, 2026 11:47
gnapse
approved these changes
Oct 17, 2026
doist-release-bot Bot
added a commit
that referenced
this pull request
Oct 17, 2026
## [3.6.1](v3.6.0...v3.6.1) (2026-10-17) ### Bug Fixes * serve the refreshed icon at the old path ([#82](#82)) ([ab08038](ab08038))
Contributor
|
🎉 This PR is included in version 3.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
#79 moved the icon to
comms-cli_512px.pngand deletedicons/comms-cli.png. Everytdcrelease so far (latest is 3.6.0) sends that old raw GitHub URL aslogo_uriwhen it registers a client, and Todoist stores the URL once and never refreshes it. So every Comms CLI client registered to date, and every new one until a release ships the newLOGO_URI, shows a broken consent-screen icon. This puts the refreshed icon back at the old path (same bytes ascomms-cli_512px.png), so all of them show the new icon. Thefix:title cuts a release that ships the newLOGO_URIfrom #79.icons/comms-cli.pnghas to stay permanently: clients that stored this URL keep it for good.Reference
Follows #79.
Changelog
Fix the missing consent-screen icon for clients registered by older versions.
Test plan
https://github.com/raw/doist/comms-cli/main/icons/comms-cli.pngonmainbefore this is merged.tdc auth loginwith an existing config, then again with a fresh config after the release.Demo