Repository navigation
Dummy monitor - #423
Dummy monitor#423raldone01 wants to merge 4 commits into
Conversation
e0779d7 to
be9bd64
Compare
dd907e6 to
32d05c8
Compare
|
does this support wayland? |
|
What do you mean exactly? The dummy monitor program itself has no issue with wayland as it uses But just try it out? |
|
Oh I just relealized this is might be casued by a mismatched pyevdi version - Could you please update this pr the latest? |
fb2ff77 to
558af9c
Compare
mkaspryk-synaptics
left a comment
There was a problem hiding this comment.
Please add a more precise description to this PR.
Here is an example template generated with Copilot that you can use:
Summary: Briefly describe what this PR changes.
Motivation / Context: Explain why the change is needed and what problem it solves.
Related work item: Link the relevant issue, bug, ticket, or user story.
Changes introduced: List the main implementation changes and any important design decisions.
How to test: Provide clear steps, including any required configuration, commands, or test data.
Testing performed: Mention the automated and manual tests that were completed, including the tested environments or platforms.
Expected result: Describe what should be observed after following the test steps.
Screenshots or logs: Include supporting screenshots, logs, or command output where applicable.
Impact and risks: Highlight possible side effects, regression risks, performance impact, or compatibility concerns.
Breaking changes: Indicate whether the PR changes any APIs, configuration, data formats, or existing behavior.
Deployment / Migration notes: Mention any special deployment steps, feature flags, migrations, or rollback considerations.
Documentation: Link the updated documentation or explain why no documentation changes are required.
Reviewer notes: Point out any areas that require particular attention and mention known limitations or planned follow-up work.
Please use it (;
Please remove all dead code and run black and flake8.
If you’re finished, I’ll take another look.
Many thanks for your contribution!
There was a problem hiding this comment.
What is the purpose of having this edid file here in this repository?
Files like EDID should be auto-generated in the code
There was a problem hiding this comment.
This repository is not the best place for files like this one.
Please remove it or change it into a set of unit tests that verify the logic of your change.
| # x_size, y_size = buffer.width, buffer.height | ||
| # for y in range(y_size): | ||
| # for x in range(x_size): | ||
| # rgb: int = buffer.bytes[y, x] | ||
| # bytes = [rgb >> 24, (rgb >> 16) & 0xFF, (rgb >> 8) & 0xFF, rgb & 0xFF] | ||
| # color = QColor(bytes[1], bytes[2], bytes[3]) | ||
| # self.image.setPixelColor(x, y, color) | ||
|
|
||
| # np_array = np.array(buffer, copy = False) # This is possible thanks to buffer protocol | ||
| # self.image = QImage(np_array, buffer.width, buffer.height, QImage.Format_RGB32) |
There was a problem hiding this comment.
Please remove this commented code.
There was a problem hiding this comment.
Please add unit tests for this file.
There was a problem hiding this comment.
Please run black and flake8 and fix PEP8 violations
There was a problem hiding this comment.
Please run black and flake8 and fix PEP8 violations
There was a problem hiding this comment.
Please add copyrights
There was a problem hiding this comment.
This repository isn't the right place for files like launch.json. Please remove it and add a README file on how to use dummy_monitor. Please add it under pyevdi/examples/dummy_monitor
There was a problem hiding this comment.
Please remove settings.json as well and move all needed information to the README file
| if options.edid_file: | ||
| edid = load_edid_file(options.edid_file) | ||
| connect_ret = card.connect(edid, len(edid), area, area * options.refresh_rate) | ||
| else: | ||
| connect_ret = card.connect(None, 0, area, area * options.refresh_rate) |
There was a problem hiding this comment.
The PR description claims the script should work with just @, but the code path that omits --edid-file still passes None to card.connect().
This pr is an extension to #421.
It adds a working dummy_monitor script.
It currently requires an edid file.
I would like it to work with just
<width>x<height>@<fps>.