Skip to content

🐞 Changes to File Icon Type setting not reflected in UI immediately #1765

Closed
Closed
🐞 Changes to File Icon Type setting not reflected in UI immediately#1765
Assignees
hkarmoush
Labels
UIThis is UI relatedbugSomething isn't workingnavigatorsettingstriage needed

Description

@austincondiff
austincondiff
opened on Jun 20, 2024

Description

When the user changes the file icon style setting, updates to the UI are not reflected immediately. Instead the user is required to change navigators to something else and then go back to the project navigator to see any UI changes.

To Reproduce

  1. Open settings
  2. Change "File Icon Type" setting
  3. Notice there are no changes to the icon color
  4. Go to another navigator
  5. Return to the project navigator
  6. Notice the icon colors changed

Expected Behavior

Icon colors should change as a direct result of your selection of the File Icon Type settings immediately without reinitializing the project navigator view.

Screenshots

Screen.Recording.2024-06-20.at.11.05.40.AM.mp4

Activity

  1. austincondiff
    added
    bugSomething isn't working
    on Jun 20, 2024
  2. austincondiff
    added this to CodeEdit Projecton Jun 20, 2024
  3. github-project-automation
    moved this to 🆕 New in CodeEdit Projecton Jun 20, 2024
  4. github-actions
    added
    navigator
    settings
    triage needed
    UIThis is UI related
    on Jun 20, 2024
  5. austincondiff
    changed the title [-]🐞 Changes to File Icon Type setting not seen in UI immediately[/-] [+]🐞 Changes to File Icon Type setting not reflected in UI immediately[/+] on Jun 20, 2024

  6. hkarmoush commented on Jun 22, 2024

    @hkarmoush
    hkarmoush
    on Jun 22, 2024
    Contributor

    Feel free to assign issue to me if there are any comments on my fix

  7. tom-ludwig
    assigned
    hkarmoush
    on Jun 22, 2024
  8. tom-ludwig
    added a commit that references this issue on Jun 23, 2024

    File Icon Type setting reflects immediately #1765 (#1773)

    f683b6b

  9. tom-ludwig commented on Jun 27, 2024

    @tom-ludwig
    tom-ludwig
    on Jun 27, 2024
    Member

    It appears that issue #1765 has been resolved with PR #1733. As a reminder, please include - closes #0000 in PR descriptions to automatically link and close related issues.

  10. tom-ludwig
    closed this as completedon Jun 27, 2024
  11. github-project-automation
    moved this from 🆕 New to 🏁 Complete in CodeEdit Projecton Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

UIThis is UI relatedbugSomething isn't workingnavigatorsettingstriage needed

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions