Skip to content

Update Porting-Buffer.md - #5

Merged
ChALkeR merged 1 commit into
ChALkeR:masterfrom
Trott:patch-1
May 26, 2018
Merged

ChALkeR merged 1 commit into
ChALkeR:masterfrom
Trott:patch-1

Conversation

@Trott

@Trott Trott commented May 26, 2018

Copy link
Copy Markdown
Contributor

Minor updates.

@ChALkeR

ChALkeR commented May 26, 2018 •

Copy link
Copy Markdown
Owner

@Trott Thanks! Will take a look at this in about an hour.

Not sure what's wrong with «behaviour», though.

@ChALkeR ChALkeR left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ChALkeR
ChALkeR merged commit f9cc772 into ChALkeR:master May 26, 2018
@Trott

Trott commented May 27, 2018

Copy link
Copy Markdown
Contributor Author

Not sure what's wrong with «behaviour», though.

I was editing this with an eye towards inclusion in the Node.js repo and the style guide there is to use US English spellings. So it's not a correction exactly, and feel free to decline that particular change if you wish.

@ChALkeR

ChALkeR commented May 27, 2018

Copy link
Copy Markdown
Owner

@Trott I already merged that, thanks ;-).
I think that both of those are fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants