Skip to content

fix: Range filter should work without needing positive/negative filter - #871

Open
borgsten wants to merge 3 commits into
COVESA:masterfrom
borgsten:bugfix/range_filter
Open

borgsten wants to merge 3 commits into
COVESA:masterfrom
borgsten:bugfix/range_filter

Conversation

@borgsten

Copy link
Copy Markdown
Contributor

There was some inconsistencies regarding how range filters worked in the current version. This PR aims to fix those,

  • It is now not required to have a positive or negative filter for range filters to work
  • Incoming logs in a live session are not appended to the table if they are outside the applied range filter
  • When a full reload of a file is done, the start/end range filter was reset. Now it is also deactivated so you do not get stuck in a "size at reload" filter range without noticing.

If you would prefer these fixes to be separate then I can split the PR but they are related and small in scope so I bundled them.

The range filter was only working while a positive or negative filter
was active, this required a dummy filter if you just want to filter on range.
While having a filter range and live receiving logs, new logs should not
be shown in the table if it is outside that range. If range filter is
not enabled there is no change to previous behavior
A full reload resets the range to the whole log once indexing finishes,
but kept the checkbox state, so the reload was still limited by the old
range. Turn the range off before it is applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant