[kaanisthatyou]

When the project lives in a directory with glob characters, like ~/Dropbox (Team)/app, absolute patterns repeat the cwd and match nothing: plugin config files aren't loaded, ignore and production exclusions miss, and subpath imports, tsconfig include and import.meta.glob resolve to nothing.

• Absolute patterns are made relative to the cwd before globbing (prependDirToPatterns, plus _syncGlob and _dirGlob).
• ignore, ignoreFiles, ignoreIssues, production and configuration hint patterns are matched against cwd-relative paths, like the gitignore matcher already does.
• The compiler extension glob takes the base of include from the relative pattern (it was cut at the ( and globbed from a parent dir).
• Nx and moonrepo expand {workspaceRoot}/$workspaceRoot to relative paths: the commands are parsed as shell scripts, and the space and parentheses in the absolute path broke them.

test/infra/glob-characters-in-cwd.test.ts copies 12 fixtures covering these cases into knip (fixture) [x]-… and expects the same issues, counters and hints as in their original location; all 12 fail without the change. From a checkout under Coding(Real)/, the full suite now gives the same results as from a plain directory (42 tests failed only there before).

[webpro]

Thanks for the pull request! Knip should just work from a directory like ~/Dropbox (Team)/app, and this fixes the reported case. Running the test suite from a checkout in such a directory, 45 tests still fail with this change, for example in ignore patterns, production mode (Vitest, node-test-runner), subpath imports, tsconfig include and import.meta.glob. Could you make the existing tests pass from such a directory, and add tests that cover these cases? One more note inline.

[webpro]

tinyglobby relativizes absolute patterns against the escaped cwd, so the cwd does need to come out of the patterns on our side. But this adds another pass over every pattern with its own ! handling. prependDirToPatterns in glob.ts already maps every pattern and checks for absolute ones, so the conversion fits in there, for example:

const prepend = (pattern: string, cwd: string, relativePath: string) => {
  const isNegated = pattern.startsWith('!');
  const id = isNegated ? pattern.slice(1) : pattern;
  const globPattern = isAbsolute(id) ? relative(cwd, id) : join(relativePath, id);
  return isNegated ? `!${globPattern}` : globPattern;
};

With that (and cwd passed in from prependDirToPatterns) instead of the change here, the new test passes, and so does every test that passes with this PR.

[kaanisthatyou]

Done in f0e99ff: the conversion now lives in prependDirToPatterns as you suggested, and the glob-core.ts change is gone. _syncGlob and _dirGlob use the same prepend, since tsconfig include, subpath imports and import.meta.glob reach tinyglobby through _syncGlob with absolute patterns.

[kaanisthatyou]

Thanks for the review and for running it from such a directory. I reproduced it with a checkout under Coding(Real)/ and compared the full suite against a copy in a plain directory: 42 tests failed only in the first one, and with these changes both give the same results. Besides the cases you listed, the configuration hints, the --use-tsconfig-files compiler extension glob and the Nx/moonrepo {workspaceRoot} expansion had the same problem. The new test/infra/glob-characters-in-cwd.test.ts covers each of them; the PR description has the details.

[webpro]

I pushed a few commits on top of yours that keep the fix but stop converting the same paths back and forth: the glob layer relativizes the workspace dir once per call and only rewrites absolute patterns, the configuration hints relativize file paths only up to the first match, package.json entry specifiers are no longer made absolute just for the glob, and tsconfig include/exclude stay relative to the tsconfig dir (rebased onto the workspace dir once for the compiler-extension glob). Knip's output on this repo is identical to your commit, the full suite passes here, and the new cases pass from a directory named knip (glob) [x] too.

Could you give it a final spin from your directory with glob characters?

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/knip@2107

npm i https://pkg.pr.new/@knip/language-server@2107

npm i https://pkg.pr.new/@knip/mcp@2107

commit: a56b827

[kaanisthatyou]

Ran the full suite at 194458c from C:\Users\ADAS\Desktop\Coding(Real)\oss-work\knip: 1392 of 1404 pass, including every "Same results in a directory with glob characters" case. The 12 failures (9 in e2e/fix-tsc, 2 in fix/format, 1 in infra/glob-symlinks) fail the same way in a copy under a plain path on this Windows machine, so they're local and unrelated to this change. Thanks for the cleanup.

[webpro]

Thanks for the confirmation! Much appreciated.

[webpro]

🚀 This pull request is included in v6.41.0. See Release 6.41.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.