[gioboa]

Closes #2011

Explicit workspace entries now override script-derived export exemptions and avoid incorrect redundancy hints.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/knip@2012

npm i https://pkg.pr.new/@knip/language-server@2012

npm i https://pkg.pr.new/@knip/mcp@2012

commit: df069d1

[usetheodev]

Reporter of #2011 here — I built this branch and ran it against the fixture from that issue, plus a control. It fixes the case I filed.

Verified

Fixture from #2011 (root scripts.dev naming a file inside a workspace, includeEntryExports: true, entry: ["src/main.ts"] in the workspace):

build	result
main @ c6497a1	Configuration hints (1) src/main.ts … Remove redundant entry pattern — exit 0, DEAD not reported
this branch @ 2e88de4	Unused exports (1) DEAD packages/app/src/main.ts:1:14 — exit 1

The misleading hint is gone too, which was half of what made this hard to notice.

The control matters: main was rebuilt from source and still reproduces, so the fix is this PR and not something between 6.32.2 (where I originally measured) and 6.34.0.

It does real work outside the fixture

Run against the repository where I found this — a pnpm monorepo whose workspace entry globs are the test files:

main @ c6497a1     exit 0, clean
+ this PR          exit 1
                   Unused exports (1)
                   omittingAGateMustNotCompile  packages/agent/src/hooks/fail-safe-defaults.test.ts:43:17

A true positive: a compile-time assertion helper, exported only so eslint would not flag an unused local. Its own docblock says "the dead-export scan lists it" — written by someone who assumed it was covered. It had never been reported, because test files are that workspace's declared entries. Exempting it locally with tags: ["-knipignore"] + /** @knipignore */ silences it cleanly, verified on this branch.

So the change surfaces genuinely invisible exports, not just fixture ones.

One case still exempt — asking rather than asserting

When the file is an entry only through the root script, with no explicit entry for it in the workspace:

// knip.jsonc
"workspaces": { "packages/app": { "entry": ["src/**/*.test.ts"], "project": ["src/**/*.ts"] } }
// root package.json
"scripts": { "dev": "node packages/app/src/main.ts" }

DEAD in packages/app/src/main.ts is still not reported on this branch (exit 0).

That may be exactly the intended semantics — an explicit declaration is a signal, and without one a script-derived entry is a program entry point whose exports are arguably its surface. #2011 asked the same question and I have no stake in the answer; I only want the boundary written down somewhere, since the option is named includeEntryExports and that case is an entry whose exports are not included.

If it is intended, the doc line is enough and the remaining fix for consumers is "declare the entry" — which this PR now makes work.

Reproduce

git fetch origin pull/2012/head:pr2012 && git switch pr2012
cd packages/knip && npx tsc
node packages/knip/bin/knip.js --no-progress   # from the fixture above

Thanks for turning this around so fast.

[webpro]

Thanks for this. The entry precedence looks right on uncached runs, but configuration changes can leave cached results stale. I'd like to see that fixed before merging.

[webpro]

Thanks!

Pushed a nit (test failed against the old implementation).

[gioboa]

Thanks @webpro

[webpro]

🚀 This pull request is included in v6.35.0. See Release 6.35.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.