Skip to content

fix(VFileInput): label click opens dialog twice - #15902

Merged
KaelWD merged 1 commit into
devfrom
fix/15888-file-input-label-click
Oct 17, 2022
Merged

KaelWD merged 1 commit into
devfrom
fix/15888-file-input-label-click

Conversation

@nekosaur

Copy link
Copy Markdown
Member

Description

alternative solution would be to stop click event propagation on textfield label altogether. not sure if that's better or not

Motivation and Context

closes #15888

How Has This Been Tested?

playground

Markup:

Details
<template>
  <v-file-input
    accept="image/*"
    label="Click me when I'm actived"
  ></v-file-input>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD KaelWD added this to the v2.6.x milestone Oct 17, 2022
@KaelWD
KaelWD merged commit a1ccbc1 into dev Oct 17, 2022
@KaelWD
KaelWD deleted the fix/15888-file-input-label-click branch October 17, 2022 17:40
KaelWD pushed a commit that referenced this pull request Oct 17, 2022

This branch was previously deployed

1 inactive deployment
Preview — f99ea465 Deployed Oct 16, 2022 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants