Repository navigation
Remove unused single-parameter list helper - #375
Merged
themidnightgospel merged 1 commit intoOct 13, 2026
Merged
themidnightgospel merged 1 commit into
themidnightgospel merged 1 commit into
Conversation
themidnightgospel
approved these changes
Oct 13, 2026
themidnightgospel
left a comment
Owner
There was a problem hiding this comment.
Reviewed (clean-review + correctness): no findings.
- The deleted helper was the only member of the generator's helper classes with no reference besides its declaration (my scan for #372 covered every
staticmember of theSyntaxFactoryHelperpartials, the*Extensionsclasses andHelpers/), so this four-line delete is the whole finding. No reference remains insrcortests, and every using in the file is still needed by the other members. - Output identity: 10 probe sets byte-identical to master 88fa458; generator suite 1016 passed (snapshots included); CI green apart from two jobs still running at review time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToSingleParameterListSyntaxhas no callers since the setup forwarders were consolidated. Remove the unused internal helper; generated output is unchanged.Validation: repository search confirms no remaining references; all 4,500 tests in the verification suite passed, including runtime suites on Roslyn 4.0, 4.4, 4.14, and 5.0. Formatting, whitespace, and generated-snapshot checks passed.
Fixes #372.