Repository navigation
Return info annotations in addition to warnings in the API - #1963
Merged
Merged
Conversation
zenador
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
March 16, 2026 02:00
2 of 4 tasks
charleskorn
reviewed
Mar 16, 2026
kakkoyun
requested changes
Mar 17, 2026
kakkoyun
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR.
I think we need to make some design decisions for the API here.
Contributor
Author
|
Hi np! I'm happy to change it if that's the better option, so let me know which is preferred and I'll update it if necessary and rebase! |
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
…tations like Prometheus does Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
return-info-annos
branch
from
July 23, 2026 18:42
3ee6518 to
687d9f1
Compare
2 of 4 tasks
zenador
added a commit
to grafana/mimir
that referenced
this pull request
Aug 18, 2026
#### What this PR does Adds an integration test to check that results with and without query sharding (within MQE with remote execution) are the same (along with the annotations). Vendors changes from prometheus/client_golang#1963, ~~but this is blocked now that main vendors a newer dskit which vendors a newer release of client_golang that doesn't include this change.~~ #### Which issue(s) this PR fixes or relates to N/A #### Checklist - [x] Tests updated. - [ ] Documentation added. - [x] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. No changelog as it's not user-facing
Merged
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Prometheus API returns infos as well as warnings, see here, we should add that here as well. This is the non-breaking change version, please let me know if you'd prefer to change the API here as well to have infos as a separate field.