Skip to content

Make --raw compatible with --hide - #486

Merged
gustavohenke merged 2 commits into
open-cli-tools:mainfrom
PoQuatre:main
Jul 3, 2024
Merged

gustavohenke merged 2 commits into
open-cli-tools:mainfrom
PoQuatre:main

Conversation

@PoQuatre

Copy link
Copy Markdown
Contributor

This PR closes #394

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 99.142% (+0.008%) from 99.134%
when pulling 523a3fe on PoQuatre:main
into 3dc909a on open-cli-tools:main.

@PoQuatre

Copy link
Copy Markdown
Contributor Author

I did some tests on my side with a package I'm working on, and it seems to work without issues, although I'm not 100% sure if I haven't missed some edge cases as I am not super familiar with the tool and the codebase

@gustavohenke gustavohenke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I don't think there's any edge case here, just some optimisations and nitpicks, but I can apply those after merging your contribution in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--hide param doesn't work with --raw output

3 participants