Repository navigation
Add support for lossy format strings - #1693
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
- Coverage 90.67% 90.61% -0.07%
==========================================
Files 38 38
Lines 16874 16945 +71
==========================================
+ Hits 15301 15354 +53
- Misses 1573 1591 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| macro_rules! error { | ||
| () => { | ||
| if self.lossy { Item::Literal(&original[..error_len]) } else { Item::Error } | ||
| }; | ||
| ($ch:expr, _) => { | ||
| if self.lossy { | ||
| error_len -= $ch.len_utf8(); | ||
| remainder = &original[error_len..]; | ||
| } | ||
| }; | ||
| ($ch:expr) => {{ | ||
| error!($ch, _); | ||
| error!() | ||
| }}; | ||
| } | ||
|
|
||
| macro_rules! return_error { | ||
| () => { | ||
| return Some((remainder, error!())) | ||
| }; | ||
| ($ch:expr) => { | ||
| error!($ch, _); | ||
| return_error!(); | ||
| }; | ||
| } |
There was a problem hiding this comment.
Sorry, I don't want all this macro mess here -- there's probably too much already. Can you figure out a better way?
There was a problem hiding this comment.
The most recent commit should be good. The coverage dropped because uncovered paths that used to be one line are now several.
b9980ec to
6e382d2
Compare
6e382d2 to
e578eb4
Compare
djc
left a comment
There was a problem hiding this comment.
That's much better, thanks!
Wondering if lossy is the best name for this... maybe lenient or copy_invalid? Any thoughts/suggestions?
|
I agree that lossy isn't a great name, and lenient has parity with something like Java's |
|
I don't think lenient formatting is important enough to earn API exposure on every type, please confine it to the format module. |
b061027 to
80a6532
Compare
|
Fixed. |
closes #1692
@djc You described a
parse_lossyfunction, but I ended up writing anew_lossyfunction. If you think it's better to setlossyat parse time, I'm happy to change it. However, it seems better to be able to set it for theIteratordirectly.