Skip to content

TimeZone::from_posix_tz: Treat empty TZ variable as UTC - #1691

Merged
djc merged 1 commit into
chronotope:mainfrom
drinkcat:no-tz-is-utc
Apr 5, 2025
Merged

djc merged 1 commit into
chronotope:mainfrom
drinkcat:no-tz-is-utc

Conversation

@drinkcat

@drinkcat drinkcat commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

This is not technically POSIX, but glibc and musl behave that way: e.g. TZ= date returns a UTC date.

Fixes #1690.

This is not technically POSIX, but glibc and musl behave that way:
e.g. `TZ= date` returns a UTC date.
@codecov

codecov Bot commented Apr 5, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (dc068f0) to head (ce183c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
+ Coverage   90.62%   90.67%   +0.04%     
==========================================
  Files          38       38              
  Lines       16871    16872       +1     
==========================================
+ Hits        15290    15299       +9     
+ Misses       1581     1573       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
djc merged commit ebeef99 into chronotope:main Apr 5, 2025
@djc

djc commented Apr 5, 2025

Copy link
Copy Markdown
Member

Thanks!

@drinkcat

Copy link
Copy Markdown
Contributor Author

@djc not terribly urgent, but any chance we could get a release with this sometimes soon? Would be useful for uutils/coreutils. Thanks!

@drinkcat

Copy link
Copy Markdown
Contributor Author

@djc still not terribly urgent, but we'd really like to get this and #1693 for uutils/coreutils. Any chance we can get a new release? ,-) Thanks!!

@djc

djc commented Apr 29, 2025

Copy link
Copy Markdown
Member

@djc still not terribly urgent, but we'd really like to get this and #1693 for uutils/coreutils. Any chance we can get a new release? ,-) Thanks!!

See #1698.

This branch was previously deployed

1 inactive deployment
Coverage — ce183c24 Deployed Apr 5, 2025 by drinkcat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty TZ environment should use UTC, not local time

2 participants