Repository navigation
[flake8-pyi] Fix false positives on quoted annotations (PYI036) - #29274
Merged
ntBre merged 1 commit intoOct 13, 2026
Merged
Conversation
|
flake8-pyi] Fix bad-exit-annotation (PYI036) false positives on stringized annotationsflake8-pyi] Fix false positives on quoted annotations (PYI036)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bad-exit-annotation(PYI036) checked raw annotation expressions, so stringized annotations such astb: "TracebackType | None"or*args: "object"were flagged even though they mean the same thing to a type checker as the unquoted form.Each annotation check now goes through
Checker::match_maybe_stringized_annotation, covering all three paths in the rule: regular parameters, variadic*args, and@overloaded methods.Fixes #27755. This follows the approach reviewed in #27758, which was closed unmerged.
Test Plan
PYI036.pywith stringizedobject, union, variadic, and overload annotations in both correct and incorrect forms.cargo test -p ruff_linter flake8_pyi: 130 passed.