Skip to content

Update Rust toolchain to 1.99 and MSRV to 1.97 - #29047

Merged
charliermarsh merged 3 commits into
mainfrom
charlie/rust-1.99
Oct 1, 2026
Merged

charliermarsh merged 3 commits into
mainfrom
charlie/rust-1.99

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Update the Rust toolchain to 1.99.0 and the MSRV to 1.97, following our N-2 support policy.
  • Address the new Clippy warnings and preserve our existing assertion and formatting macro conventions.
  • Update Hawk to 0.1.15 and run it with Rust 1.99.0.

@charliermarsh
charliermarsh requested review from a team as code owners October 1, 2026 14:26
@astral-sh-bot
astral-sh-bot Bot requested a review from sharkdp October 1, 2026 14:26
@astral-sh-bot

astral-sh-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146.

@astral-sh-bot

astral-sh-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

@astral-sh-bot

astral-sh-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@codspeed

codspeed Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 4.05%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 110 untouched benchmarks
⏩ 111 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation ty_module_resolver[600] 40 ms 38.4 ms +4.05%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing charlie/rust-1.99 (7d0ff22) with main (56180bc)

Open in CodSpeed

Footnotes

  1. 111 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@charliermarsh
charliermarsh marked this pull request as draft October 1, 2026 14:42
@charliermarsh
charliermarsh marked this pull request as ready for review October 1, 2026 14:44
@charliermarsh charliermarsh added the internal An internal refactor or improvement (not for changelogs) label Oct 1, 2026
@charliermarsh charliermarsh added dependencies Issues relating to dependencies, or PRs that update a dependency file and removed internal An internal refactor or improvement (not for changelogs) labels Oct 1, 2026
@charliermarsh
charliermarsh merged commit 41d30df into main Oct 1, 2026
73 checks passed
@charliermarsh
charliermarsh deleted the charlie/rust-1.99 branch October 1, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Issues relating to dependencies, or PRs that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants