Repository navigation
Introduce new SemVer policies - #1424
Conversation
- add more SemVer implementations - improve documentation - improve tests for version policies
|
For me the overall goal is a bit unclear. Usually release policies only make sense if they are always the same (not only used for a single release), otherwise one could just as well override the default versions with explicit parameters. With SemVer however the version numbering always depends on the underlying changes. There is no way to automatically tell which part of the version you need to increment. Toggling the release policy for each release does not make much sense to me. Why not stick with the default and rely on the release manager to set the right version then? |
|
Agree that release manager depends on change log for release take a decision about next version. In system when release is made by CI we have currently two options
With more flexible versions policy we can provide an option in CI which allow to select which version should be changed
|
|
If this is just about being able to release in non-interactive mode, why not just setting parameter |
|
I don't want to change project source code before each release.
My idea is to have an option in CI pipeline, when release manage start a new release, can select one simple option on CI level without entering manual values for next version. Settings Like for GitHub workflow we can provide an input parameter - https://github.com/proxy/docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onworkflow_dispatchinputs - there is a |
|
Now I see, so |
It depends if someone alway want to bump eg minor version (never mind of reason) for all releases can set it in project pom.xml But yes I think about using by CI on cli level What is your proposition for documentation improvement? |
|
@kwin do you have more objections, I would like to merge it and finally release next version |
| * | ||
| * @since 3.3.0 | ||
| */ | ||
| abstract class AbstarctSemVerVersionPolicy implements VersionPolicy { |
There was a problem hiding this comment.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.