Repository navigation
edit tests - #2344
Closed
nlf wants to merge 4 commits into
Closed
edit tests#2344nlf wants to merge 4 commits into
nlf wants to merge 4 commits into
Conversation
darcyclarke
approved these changes
Dec 15, 2020
ruyadorno
approved these changes
Dec 15, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored the edit command to remove its dependence on the
editorlibrary, also wrote tests for it.i also took the liberty of refactoring the
editordependency out oflib/config.jsand removed the dependency entirely, since we no longer need it.References
Closes npm/statusboard#149
Depends on #2342 for the "rebuild after exit" functionality to work, but tests will pass without it