Repository navigation
Add native targeted scrolling - #70
Merged
Merged
Conversation
This was referenced Oct 5, 2026
iamnbutler
force-pushed
the
codex/desktop-pointer
branch
from
October 5, 2026 12:08
cbd895e to
0029579
Compare
iamnbutler
changed the base branch from
codex/desktop-keyboard
to
feat/github-cache
October 5, 2026 12:08
iamnbutler
marked this pull request as ready for review
October 5, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
desktop_scrollfor an observed element or normalized screenshot point, with up/down/left/right direction and 1–20 native scroll units. It reuses exact snapshot/window authority, background delivery, and pi's unsafe-tool outcome handling. The request retains the snapshot's original focus evidence so a successfully delivered scroll's signed receipt verifies correctly.Part of githubnext/desktop-tools#2 and #8. This focused diff preserves the landed click, app-search, and window-management tools. Drag work remains on
codex/desktop-dragfor a separate PR.Validation:
d9b0c869candidate passed five real AppKit scrolls: element down, point down revealing initially offscreen content, element up, point right, and element left.f1682d028a9f810c93c103286949c1ad69c8ef13passed type checks, formatting/lint, Swift parsing, diff checks, and independent source review. The scroll implementation is unchanged from the signed candidate; no new signed build was made for the extraction/base integration.Hosted workspace execution, worker-crash replay, self-Ace scrolling, multi-display/Retina/second-machine behavior, and the later invalid/moved-window checks remain unverified. Pixels-only observations do not provide reusable pointer authority. githubnext/desktop-tools#2 stays open for those checks and the remaining drag scope.
Built in Ace
Git/GitHub operations, checks, signed candidate/fixture builds, and committed-range review ran in a dedicated Ace terminal. The extraction was also reviewed through Ace's changes/patch APIs. Native and real-provider checks used Ace's signed bridge, actual tool schema/host adapter, and real receiver state.
Codex's external file/command tools handled source edits, log/receipt inspection, temporary helper preparation, and review coordination because Ace lacks external harness integration (#9) and a file-editing surface (#22).