Repository navigation
Conversation
…by core and ecosystem (AI-assisted) Cover the path patterns that Docusaurus core and the ecosystem (plugins getPathsToWatch() of the top 150 npm Docusaurus packages) pass to watch(), to prepare the Chokidar v3 -> v5 upgrade. Known Chokidar v3 per-platform inconsistencies are documented with TODO comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 3 tasks
slorber
changed the base branch from
claude/docusaurus-glob-watch-tests-16601b
to
main
October 2, 2026 15:46
…b-watch-tests-16601b
…ort (AI-assisted) Chokidar v4+ removed glob support. As suggested in paulmillr/chokidar#1423, we watch the base dir of each glob, and ignore files that don't match any glob. Only Node.js native APIs are used: path.matchesGlob() for matching, and a minimal glob base dir extraction. The Watcher type stays narrowed to file events. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
force-pushed
the
claude/glob-watch-chokidar-v5-native
branch
from
October 2, 2026 16:01
0fee60b to
dfd18c3
Compare
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.4 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.6 MB ℹ️ View Unchanged
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
POC: upgrade Chokidar from v3 to v5, which removed glob support, using only Node.js native glob APIs. Competing attempt: #12548 (micromatch).
As suggested in paulmillr/chokidar#1423,
watch()now:scanGlob()function (docs/**/*.{md,mdx}→docs), and plain file/dir paths as isignoredoption to ignore files that don't match any glob, with Node.jspath.matchesGlob()!pattern)No glob library is used for watching. The
watch()tests of #12492 are left unchanged on purpose: failures show the behavior changes compared to Chokidar v3.Test Plan
Results of the #12492
watch()tests (106 tests, unchanged):cwdoption (docusaurus-plugin-structurizr)docs/**/*.mddoes not matchdocs/.dotfile.md):path.matchesGlob()has nodotoptionfs.watch())CI results on Linux and Windows (native + polling), compared to the Chokidar v3 expectations of #12492:
siteDir,node_modules, pnpm store paths), multiple and overlapping paths, docs plugin paths.i18n/fr/docusaurus-plugin-content-docs/current/**,../docs/**), on Linux and Windowscwdoption on Linux (docusaurus-plugin-structurizr), but not on Windowsdocs/**/*.mddoes not matchdocs/.dotfile.md), on all platforms:path.matchesGlob()has nodotoptionTest links
Deploy preview: https://deploy-preview-12549--docusaurus-2.netlify.app/
Related issues/PRs
main, but includes the commits of test(glob): add FS watch tests for all watch() path patterns used by core and ecosystem (AI-assisted) #12492 (watch()tests): only the last commit is part of this POC. GitHub stacks are linear, and the competing attempt feat(glob): POC upgrade to Chokidar v5, with micromatch glob support (AI-assisted) #12548 is the one stacked on top of test(glob): add FS watch tests for all watch() path patterns used by core and ecosystem (AI-assisted) #12492(AI-assisted)
🤖 Generated with Claude Code