[openipc-ai]

Moves the majestic-af pin from 2d3475e to 1fda430, picking up three changes:

• schema: tell majestic which drivers exist, so a new one shows up in the WebUI majestic-af#28: the plugin tells majestic which drivers exist. A new driver shows up in the WebUI's protocol list without a majestic change.
• ptz: report the serial line as it was opened, not as the config says majestic-af#29: /ptz reports the serial line as it was opened. It used to report what the config said. A rate the port cannot be set to now shows as the 115200 the port actually falls back to.
• ptz: the settings are under ptz, and the Pelco device address is one of them majestic-af#30: settings under ptz, and the Pelco device address (PTZ settings majestic#341). majestic now keeps the motor settings in its ptz block:
  • isp.autofocus.speed → ptz.baud
  • isp.autofocus.mode → ptz.focusMode
  • the rest keep their names
  • new ptz.address: the receiver address, 0–255, default 1. A Pelco-D head strapped to an address other than 1 can now be driven.

This bump has to land with tonight's majestic. majestic master already reads ptz. The plugin at the current pin still reads isp.autofocus, so it cannot drive the lens under a majestic from today on. This PR and the majestic nightly need to reach the same image.

Before and after on the lab hi3516ev300 with an 85H50AI lens (ptz_control=pelco-xm). Both runs used the same majestic master build; only the plugin was swapped.

	Plugin at 2d3475e (current pin)	Plugin at 1fda430 (this bump)
GET /ptz	speed=-2147483648, no addr=	speed=115200 addr=1 state=ready
POST /ptz?move=tele	unavailable	moving tele, zoom x3.3 → x3.6, and wide back to x3.3
Set ptz.address=5	—	Log: reopened the motor port without rebuilding the pipeline. /ptz reports addr=5, and the frames go out as c5 05 00 20 00 00 25 5c

The XiongMai lens board ignores the address byte, as it already ignores the checksum: it zoomed the same at 1, 2 and 5. The address only matters for a real Pelco-D head. majestic-af's own tests (9/9) pass at 1fda430, and its .so builds with the package's MinSizeRel options.

[openipc-ai]

/review

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. SPI users follow a setting that is ignored ✓ Resolved

Description

The version bump switches to a plugin that reads motor settings under ptz, but Config.in still
tells MS41908M users to set isp.autofocus.actuator=ms41908. On the Hi3516A/D V100 boards named in
that help text, following the documented setup does not pass the actuator selection to the bumped
plugin.

Code

general/package/majestic-af/majestic-af.mk[8]

+MAJESTIC_AF_VERSION = 1fda430c793db9063520810d717662422ee042e2

Evidence

The changed pin selects the new plugin version; the package help explicitly instructs users of the
SPI actuator to configure it with the old isp.autofocus prefix. The PR's stated settings migration
places the retained actuator name under ptz.

general/package/majestic-af/majestic-af.mk[7-8]
general/package/majestic-af/Config.in[9-12]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The bumped plugin expects motor settings under `ptz`, while the package help still gives SPI lens users an `isp.autofocus` actuator key.
## Fix Focus Areas
- general/package/majestic-af/Config.in[10-12]
## Recommended Fix
Change the MS41908M setup example to `ptz.actuator=ms41908`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Tip of the day

💡 Did you know, you can turn these tips off under Display > Comment parts

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗