Skip to content

[textDocument/rename] client doesn't obey RenameOptions while registering provider #416

Closed

Description

@Talv

prepareRename handler can't be registered because options.prepareProvider is never being set, even if server does include it in its capabilities.

Fix:

--- a/client/src/client.ts
+++ b/client/src/client.ts
@@ -2002,7 +2002,7 @@ class RenameFeature extends TextDocumentFeature<RenameRegistrationOptions> {
                }
                this.register(this.messages, {
                        id: UUID.generateUuid(),
-                       registerOptions: Object.assign({}, { documentSelector: documentSelector })
+                       registerOptions: Object.assign({}, { documentSelector: documentSelector }, capabilities.renameProvider)
                });
        }

https://github.com/Microsoft/vscode-languageserver-node/blob/d168533600cafd64023cade9f2b5e6dee74134d4/client/src/client.ts#L2005

Activity

  1. dbaeumer commented on Oct 16, 2018

    @dbaeumer
    Member

    Talv very good catch. And sorry for the late response.

  2. dbaeumer commented on Oct 16, 2018

    @dbaeumer
    Member
  3. rcjsuen commented on Oct 16, 2018

    @rcjsuen
    Contributor

    Good to know for future contributions.

    Thanks for catching this, Talv!

  4. locked and limited conversation to collaborators on Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions