Skip to content

Colorization of JSX code in VS 2015 #4835

Closed

Description

Hi,

I've installed TypeScript 1.6 and tried to replace my .jsx files with .tsx. Everything works as expected except that JSX code is not colorized. I've tried to reset my "Fonts and Colors" settings, but nothing helps.

tsx

Is that supposed to work? Is there any way to fix this?

Thank you!

Activity

  1. DanielRosenwasser commented on Sep 17, 2015

    @DanielRosenwasser
    Member

    This is actually a known issue and is unfortunately we won't have proper colorization for JSX until we reactivate the syntactic classifier. I'm not entirely sure when that will be. Cyrus Najmabadi (@CyrusNajmabadi) might know more about this.

  2. matijagrcic commented on Dec 21, 2015

    @matijagrcic

    Daniel Rosenwasser (@DanielRosenwasser) Cyrus Najmabadi (@CyrusNajmabadi) Except for colorization and formatting could you provide support for emmet, something as VS code did in microsoft/vscode#732?

  3. DanielRosenwasser commented on Dec 23, 2015

    @DanielRosenwasser
    Member

    I feel like that might be out of scope, since another project could always use our language service to implement the same functionality. Still, I'm not that familiar with emmet and others might disagree.

    You're more than welcome to open up a separate issue, and if you do, if you could give a quick description on emmet itself with a link that would be much appreciated.

  4. 19 remaining items

  5. matijagrcic commented on Jan 28, 2016

    @matijagrcic

    This is working great with TypeScript 1.8.

    2016-01-28 22_12_53-typescriptreact - microsoft visual studio

    TypeScript_Dev14Full.exe download

    Thanks for all the hard work!

  6. olmobrutall commented on Jan 28, 2016

    @olmobrutall

    Awesome team and awesome language. Thanks a lot!

  7. techird commented on Jan 29, 2016

    @techird

    Really productive!!

  8. djanosik commented on Jan 29, 2016

    @djanosik
    Author

    Is it intentional that colors used for tags, attributes and inner text are different from colors used in .cshtml or .jsx files? What colors I need to redefine to make it look the same?

  9. djanosik commented on Jan 29, 2016

    @djanosik
    Author

    Well, it looks it uses colors for VB XML Literals instead of colors for XML or HTML. That feels wrong.

  10. olmobrutall commented on Jan 29, 2016

    @olmobrutall

    I think it makes sense. This is markup inside code like in VB, no code inside markup like in cshtml.

    I think .jsx are wrong and .tsx right.

  11. djanosik commented on Jan 30, 2016

    @djanosik
    Author

    It makes sense, but it should be consistent at least.

  12. olmobrutall commented on Jan 30, 2016

    @olmobrutall

    I've found colorization errors about this feature using Inner Types. I posted a separated issue #6756

  13. paulvanbrenk commented on Jan 30, 2016

    @paulvanbrenk
    Contributor

    Dusan Janosik (@djanosik) this inconsistency is because the jsx support was originally implemented by the ASP.NET team and the tsx support by the TypeScript team. We have a plan to unify this, however no clear timeline yet; the next version of Visual Studio is more likely than an interim release of TypeScript.

  14. djanosik commented on Jan 30, 2016

    @djanosik
    Author

    Paul van Brenk (@paulvanbrenk) Good to know. I've changed VB XML Literals colors because it's not readable when you use Dark color theme.

  15. CyrusNajmabadi commented on Feb 1, 2016

    @CyrusNajmabadi
    Contributor

    pinging David Poeschl (@dpoeschl) . Hey David, is is a known issue that the VB xml literal colors aren't readonable in the Dark theme? Sounds like something we'd want to fix for both VB and TypeScript.

  16. nippur72 commented on Apr 12, 2016

    @nippur72

    what are the VB XML color code-names for <, >, /, = ?

    I would like to colorize the whole component definition, delimiters included.

    Also, it would be nice if code within JSX expressions ({ }) had a custom background (slightly lighter or darker) like in the razor syntax.

  17. paulvanbrenk commented on Apr 12, 2016

    @paulvanbrenk
    Contributor

    nino-porcino (@nippur72) I don't think VB XML literals has configurable options for the delimiters, at least I couldn't find them.

    I'll see if I can use the VB XML Literals - Embedded Expression color for the JSX expressions, but that may look terrible.

  18. locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptFixedA PR has been merged for this issueVisual StudioIntegration with Visual Studio

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions