You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've installed TypeScript 1.6 and tried to replace my .jsx files with .tsx. Everything works as expected except that JSX code is not colorized. I've tried to reset my "Fonts and Colors" settings, but nothing helps.
Is that supposed to work? Is there any way to fix this?
This is actually a known issue and is unfortunately we won't have proper colorization for JSX until we reactivate the syntactic classifier. I'm not entirely sure when that will be. Cyrus Najmabadi (@CyrusNajmabadi) might know more about this.
I feel like that might be out of scope, since another project could always use our language service to implement the same functionality. Still, I'm not that familiar with emmet and others might disagree.
You're more than welcome to open up a separate issue, and if you do, if you could give a quick description on emmet itself with a link that would be much appreciated.
Is it intentional that colors used for tags, attributes and inner text are different from colors used in .cshtml or .jsx files? What colors I need to redefine to make it look the same?
Dusan Janosik (@djanosik) this inconsistency is because the jsx support was originally implemented by the ASP.NET team and the tsx support by the TypeScript team. We have a plan to unify this, however no clear timeline yet; the next version of Visual Studio is more likely than an interim release of TypeScript.
pinging David Poeschl (@dpoeschl) . Hey David, is is a known issue that the VB xml literal colors aren't readonable in the Dark theme? Sounds like something we'd want to fix for both VB and TypeScript.
Activity
DanielRosenwasser commentedon Sep 17, 2015
This is actually a known issue and is unfortunately we won't have proper colorization for JSX until we reactivate the syntactic classifier. I'm not entirely sure when that will be. Cyrus Najmabadi (@CyrusNajmabadi) might know more about this.
matijagrcic commentedon Dec 21, 2015
Daniel Rosenwasser (@DanielRosenwasser) Cyrus Najmabadi (@CyrusNajmabadi) Except for colorization and formatting could you provide support for emmet, something as VS code did in microsoft/vscode#732?
DanielRosenwasser commentedon Dec 23, 2015
I feel like that might be out of scope, since another project could always use our language service to implement the same functionality. Still, I'm not that familiar with emmet and others might disagree.
You're more than welcome to open up a separate issue, and if you do, if you could give a quick description on emmet itself with a link that would be much appreciated.
19 remaining items
matijagrcic commentedon Jan 28, 2016
This is working great with TypeScript 1.8.
TypeScript_Dev14Full.exe download
Thanks for all the hard work!
olmobrutall commentedon Jan 28, 2016
Awesome team and awesome language. Thanks a lot!
techird commentedon Jan 29, 2016
Really productive!!
djanosik commentedon Jan 29, 2016
Is it intentional that colors used for tags, attributes and inner text are different from colors used in
.cshtmlor.jsxfiles? What colors I need to redefine to make it look the same?djanosik commentedon Jan 29, 2016
Well, it looks it uses colors for
VB XML Literalsinstead of colors forXMLorHTML. That feels wrong.olmobrutall commentedon Jan 29, 2016
I think it makes sense. This is markup inside code like in VB, no code inside markup like in cshtml.
I think .jsx are wrong and .tsx right.
djanosik commentedon Jan 30, 2016
It makes sense, but it should be consistent at least.
olmobrutall commentedon Jan 30, 2016
I've found colorization errors about this feature using Inner Types. I posted a separated issue #6756
paulvanbrenk commentedon Jan 30, 2016
Dusan Janosik (@djanosik) this inconsistency is because the
jsxsupport was originally implemented by the ASP.NET team and thetsxsupport by the TypeScript team. We have a plan to unify this, however no clear timeline yet; the next version of Visual Studio is more likely than an interim release of TypeScript.djanosik commentedon Jan 30, 2016
Paul van Brenk (@paulvanbrenk) Good to know. I've changed
VB XML Literalscolors because it's not readable when you use Dark color theme.CyrusNajmabadi commentedon Feb 1, 2016
pinging David Poeschl (@dpoeschl) . Hey David, is is a known issue that the VB xml literal colors aren't readonable in the Dark theme? Sounds like something we'd want to fix for both VB and TypeScript.
nippur72 commentedon Apr 12, 2016
what are the VB XML color code-names for
<,>,/,=?I would like to colorize the whole component definition, delimiters included.
Also, it would be nice if code within JSX expressions (
{ }) had a custom background (slightly lighter or darker) like in the razor syntax.paulvanbrenk commentedon Apr 12, 2016
nino-porcino (@nippur72) I don't think VB XML literals has configurable options for the delimiters, at least I couldn't find them.
I'll see if I can use the
VB XML Literals - Embedded Expressioncolor for the JSX expressions, but that may look terrible.