Skip to content

ImageData constructor signature is incorrect #4220

Closed
Closed
ImageData constructor signature is incorrect#4220
Labels
Breaking ChangeWould introduce errors in existing codeBugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issue
Milestone
TypeScript 1.6

Description

@jteplitz
Jason Teplitz (jteplitz)
opened on Aug 7, 2015

lib.d.ts (and lib.webworkers.d.ts) define the ImageData constructor constructor as taking no arguments, but there should actually be two constructor signatures of the following form according to mdn:

new ImageData(array, width, height);
new ImageData(width, height);

Activity

  1. Ryan Cavanaugh (RyanCavanaugh)
    added
    BugA bug in TypeScript
    Help WantedYou can do this
    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScript
    on Aug 7, 2015
  2. Jason Teplitz (jteplitz)
    added a commit that references this issue on Aug 7, 2015

    Fix microsoft#4220: Fix ImageData Constructor Signature in ES6 Browsers

    43cf3b3

  3. jteplitz commented on Aug 7, 2015

    @jteplitz
    Jason Teplitz (jteplitz)
    on Aug 7, 2015
    Author

    Submitted PR #4224 to fix this. It looks like the constructor is only defined in ES6 compatible browsers so I've only added the definition in lib.es6 and lib.webworkers

  4. Mohamed Hegazy (mhegazy)
    removed
    Help WantedYou can do this
    on Aug 7, 2015

  5. mhegazy commented on Aug 7, 2015

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Aug 7, 2015
    Contributor

    We can not accept a PR for this. sorry for the wrong tag. this file is auto generated. we have to update the script that generates this. We should post the sources of this script on another repo to allow the community to update it for similar issues. until then, Zhengbo Li (@zhengbli) will take care of this bug.

  6. Mohamed Hegazy (mhegazy)
    added this to the TypeScript 1.6 milestone on Aug 7, 2015
  7. Mohamed Hegazy (mhegazy)
    assigned
    Zhengbo Li (zhengbli)
    on Aug 7, 2015
  8. Mohamed Hegazy (mhegazy)
    added
    Breaking ChangeWould introduce errors in existing code
    on Aug 19, 2015
  9. Zhengbo Li (zhengbli)
    closed this as completedon Aug 20, 2015
  10. Mohamed Hegazy (mhegazy)
    added
    FixedA PR has been merged for this issue
    on Aug 20, 2015
  11. microsoft
    locked and limited conversation to collaborators on Jun 19, 2018
  12. TypeScript Bot (typescript-bot)
    unassigned
    Zhengbo Li (zhengbli)
    on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking ChangeWould introduce errors in existing codeBugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptFixedA PR has been merged for this issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions